Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NLP] Add prefix_string config option to the import model hub script #642

Merged
merged 2 commits into from
Jan 19, 2024
Merged

[NLP] Add prefix_string config option to the import model hub script #642

merged 2 commits into from
Jan 19, 2024

Conversation

davidkyle
Copy link
Member

The prefix_strings option was added in elastic/elasticsearch#102089 to support the E5 model.

The new params to eland_import_hub_model are --search-prefix and --ingest-prefix

Example usage

eland_import_hub_model       
  --url 'http://localhost:9200'
  --hub-model-id intfloat/multilingual-e5-small       
  --task-type text_embedding 
  --search-prefix "query: " 
  --ingest-prefix "passage: "

This option is only available in Elasticsearch 8.12 and depends on elastic/elasticsearch-specification#2363

@davidkyle davidkyle added enhancement New feature or request topic:NLP Issue or PR about NLP model support and eland_import_hub_model labels Dec 8, 2023
@davidkyle davidkyle marked this pull request as ready for review January 18, 2024 17:40
@davidkyle davidkyle mentioned this pull request Jan 18, 2024
Merged
joshdevins
joshdevins approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@joshdevins joshdevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this documented somewhere in docs too?

@pquentin pquentin merged commit 64216d4 into elastic:main Jan 19, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdevins joshdevins joshdevins approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request topic:NLP Issue or PR about NLP model support and eland_import_hub_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidkyle @joshdevins @pquentin